fix: do not emit unlistened transport error before connect completes - #297
Merged
Conversation
A socket error before the transport reached the connected phase emitted 'error' with no listener attached, crashing the process with ERR_UNHANDLED_ERROR instead of rejecting connect().
mykola-mokhnach
approved these changes
Aug 21, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
## [5.14.7](v5.14.6...v5.14.7) (2026-08-21) ### Bug Fixes * do not emit unlistened transport error before connect completes ([#297](#297)) ([0d0e3c4](0d0e3c4))
|
🎉 This PR is included in version 5.14.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A socket error before the transport reached the connected phase emitted 'error' with no listener attached. That crashed the process with ERR_UNHANDLED_ERROR instead of rejecting connect().
The transport now suppresses the emit outside the connected phase so connect() rejects cleanly. Connected phase errors still emit as before.
Adds unit tests covering both phases.